Paths

Table of Contentst

Differential D20146

Add version check whitelists for constants to the version compatibility lint rule
ClosedPublic
Actions

Authored by epriestley on Feb 11 2019, 10:25 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13249: 2019 Week 7 - 10 Bonus Content

Commits

rARC7e61e43f6554: Add version check whitelists for constants to the version compatibility lint…

Summary

Ref T13249. We currently allow if (function_exists('X')) { X(); } but not if (defined('X')) { X; }. Allow the latter.

Test Plan

See D20145, which linted clean with this patch in place.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 11 2019, 10:25 PM

epriestley added inline comments.Feb 11 2019, 10:26 PM

src/lint/linter/__tests__/jshint/jshint.lint-test
12	This is unrelated, reflects a behavioral change in newer versions of jshint.

Harbormaster completed remote builds in B21931: Diff 48092.Feb 11 2019, 10:26 PM

epriestley requested review of this revision.Feb 11 2019, 10:26 PM

amckinley accepted this revision.Feb 11 2019, 11:18 PM

This revision is now accepted and ready to land.Feb 11 2019, 11:18 PM

Closed by commit rARC7e61e43f6554: Add version check whitelists for constants to the version compatibility lint… (authored by epriestley). · Explain WhyFeb 12 2019, 1:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

jshint/

jshint.lint-test

2 lines

xhpast/

rules/

ArcanistPHPCompatibilityXHPASTLinterRule.php

39 lines

Diff 48104

View Options

src/lint/linter/tests/jshint/jshint.lint-test

View Options

src/lint/linter/xhpast/rules/ArcanistPHPCompatibilityXHPASTLinterRule.php

Add version check whitelists for constants to the version compatibility lint ruleClosedPublicActions