Ref T13249. We currently allow if (function_exists('X')) { X(); } but not if (defined('X')) { X; }. Allow the latter.
Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13249: 2019 Week 7 - 10 Bonus Content
- Commits
- rARC7e61e43f6554: Add version check whitelists for constants to the version compatibility lint…
See D20145, which linted clean with this patch in place.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- lint2
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21931 Build 29949: Run Core Tests Build 29948: arc lint + arc unit
Event Timeline
| src/lint/linter/__tests__/jshint/jshint.lint-test | ||
|---|---|---|
| 12 | This is unrelated, reflects a behavioral change in newer versions of jshint. | |