Page MenuHomePhabricator

Fix a remarkup rule for `[x](y)` links when "y" is the empty string
ClosedPublic

Authored by epriestley on Feb 11 2019, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 2, 8:36 AM
Unknown Object (File)
Thu, Jan 30, 3:42 AM
Unknown Object (File)
Sun, Jan 26, 7:50 PM
Unknown Object (File)
Sun, Jan 26, 7:50 PM
Unknown Object (File)
Sun, Jan 26, 7:50 PM
Unknown Object (File)
Sun, Jan 26, 7:50 PM
Unknown Object (File)
Fri, Jan 17, 2:42 PM
Unknown Object (File)
Fri, Jan 17, 1:44 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/uninitialized-string-offset-error-in-phutilremarkupdocumentlinkrule/2379. This test is incorrect (should be against $uri, not $uri[0]) and should happen before we access $uri[0]).

Test Plan
  • Entered [x](), no more error in the logs.
  • Entered [x](http://example.com), got a link.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable