Differential D20095

Replace "Add Auth Provider" radio buttons with a more modern "click to select" UI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2019, 2:10 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T6703: Allow multiple copies of the same auth provider type
T13244: 2019 Week 6 Bonus Content

Commits

rP8c8d56dc5636: Replace "Add Auth Provider" radio buttons with a more modern "click to select"…

Summary

Depends on D20094. Ref T13244. Ref T6703. See PHI774. Currently, we use an older-style radio-button UI to choose an auth provider type (Google, Password, LDAP, etc).

Instead, use a more modern click-to-select UI.

Test Plan

Screen Shot 2019-02-05 at 5.59.31 AM.png (1×2 px, 365 KB)

Diff Detail

Repository

rP Phabricator

Branch

welcome2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21826
Build 29782: Run Core Tests
Build 29781: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 5 2019, 2:10 PM

Harbormaster completed remote builds in B21826: Diff 47983.Feb 5 2019, 2:12 PM

epriestley requested review of this revision.Feb 5 2019, 2:12 PM

epriestley added a child revision: D20096: Move the Auth Provider edit flow toward a more modern layout.Feb 5 2019, 3:13 PM

amckinley accepted this revision.Feb 5 2019, 8:35 PM

This revision is now accepted and ready to land.Feb 5 2019, 8:35 PM

Closed by commit rP8c8d56dc5636: Replace "Add Auth Provider" radio buttons with a more modern "click to select"… (authored by epriestley). · Explain WhyFeb 5 2019, 10:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

application/

PhabricatorAuthApplication.php

3 lines

controller/

config/

PhabricatorAuthEditController.php

6 lines

PhabricatorAuthNewController.php

127 lines

provider/

PhabricatorAuthProvider.php

6 lines

Diff 47983

View Options

src/applications/auth/application/PhabricatorAuthApplication.php

View Options

src/applications/auth/controller/config/PhabricatorAuthEditController.php

View Options

src/applications/auth/controller/config/PhabricatorAuthNewController.php

View Options

src/applications/auth/provider/PhabricatorAuthProvider.php

Replace "Add Auth Provider" radio buttons with a more modern "click to select" UIClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47983

src/applications/auth/application/PhabricatorAuthApplication.php

src/applications/auth/controller/config/PhabricatorAuthEditController.php

src/applications/auth/controller/config/PhabricatorAuthNewController.php

src/applications/auth/provider/PhabricatorAuthProvider.php

Replace "Add Auth Provider" radio buttons with a more modern "click to select" UI
ClosedPublic
Actions

Revision Contents
Changeset List