Differential D20095

Replace "Add Auth Provider" radio buttons with a more modern "click to select" UI
ClosedPublic
Actions

Authored by epriestley on Feb 5 2019, 2:10 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T6703: Allow multiple copies of the same auth provider type
T13244: 2019 Week 6 Bonus Content

Commits

rP8c8d56dc5636: Replace "Add Auth Provider" radio buttons with a more modern "click to select"…

Summary

Depends on D20094. Ref T13244. Ref T6703. See PHI774. Currently, we use an older-style radio-button UI to choose an auth provider type (Google, Password, LDAP, etc).

Instead, use a more modern click-to-select UI.

Test Plan

Diff Detail

Repository

rP Phabricator

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Feb 5 2019, 2:10 PM

Harbormaster completed remote builds in B21826: Diff 47983.Feb 5 2019, 2:12 PM

epriestley requested review of this revision.Feb 5 2019, 2:12 PM

epriestley added a child revision: D20096: Move the Auth Provider edit flow toward a more modern layout.Feb 5 2019, 3:13 PM

amckinley accepted this revision.Feb 5 2019, 8:35 PM

This revision is now accepted and ready to land.Feb 5 2019, 8:35 PM

Closed by commit rP8c8d56dc5636: Replace "Add Auth Provider" radio buttons with a more modern "click to select"… (authored by epriestley). · Explain WhyFeb 5 2019, 10:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/applications/auth/application/PhabricatorAuthApplication.php (3 lines)
M			src/applications/auth/controller/config/PhabricatorAuthEditController.php (6 lines)
M			src/applications/auth/controller/config/PhabricatorAuthNewController.php (127 lines)
M			src/applications/auth/provider/PhabricatorAuthProvider.php (6 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	47983	351b46a		Feb 5 2019, 2:10 PM	★	★
Diff 2	48004	6f3bd13	rP8c8d56dc5636df949e7bacf77abfeb9e51be7b65	Feb 5 2019, 10:18 PM	★	★

Status	Author	Revision
Closed	epriestley	D20102 Remove one-time login from username change email
Closed	epriestley	D20100 Always allow users to login via email link, even if an install does not use passwords
Closed	epriestley	D20099 Remove obsolete "PhabricatorAuthLoginHandler"
Closed	epriestley	D20096 Move the Auth Provider edit flow toward a more modern layout
Closed	epriestley	D20095 Replace "Add Auth Provider" radio buttons with a more modern "click to select" UI
Closed	epriestley	D20094 Begin adding more guidance to the "One-Time Login" flow