Page MenuHomePhabricator

Correct a bug where milestone "spacePHID" columns could become desynchronized
ClosedPublic

Authored by epriestley on Jan 30 2019, 2:04 AM.
Tags
None
Referenced Files
F15544803: D20063.diff
Sat, Apr 26, 7:06 AM
F15543523: D20063.id47898.diff
Fri, Apr 25, 10:52 PM
F15506106: D20063.id47898.diff
Tue, Apr 15, 8:43 AM
F15477813: D20063.id47930.diff
Mon, Apr 7, 5:53 PM
F15477812: D20063.id47898.diff
Mon, Apr 7, 5:53 PM
F15477810: D20063.id.diff
Mon, Apr 7, 5:52 PM
F15455108: D20063.diff
Sat, Mar 29, 10:15 PM
F15432873: D20063.id47930.diff
Mar 24 2025, 8:03 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20041. See PHI1046. If you do this:

  • Create a parent project called "Crab" in Space 1.
  • Create a milestone called "Left Claw".
  • Shift "Crab" to Space 2.
  • Create a milestone called "Right Claw".

...you currently end up with "Left Claw" in the wrong spacePHID in the database. At the application level it's in the correct space, but when we WHERE ... AND spacePHID IN (...) we can incorrectly filter it out.

Test Plan
  • Did the above setup.
  • Saved "Crab", saw the space fix itself.
  • Put things back in the broken state.
  • Ran the migration script, saw things fix themselves again.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable