Page MenuHomePhabricator

Correct a bug where milestone "spacePHID" columns could become desynchronized
ClosedPublic

Authored by epriestley on Jan 30 2019, 2:04 AM.

Details

Summary

Depends on D20041. See PHI1046. If you do this:

  • Create a parent project called "Crab" in Space 1.
  • Create a milestone called "Left Claw".
  • Shift "Crab" to Space 2.
  • Create a milestone called "Right Claw".

...you currently end up with "Left Claw" in the wrong spacePHID in the database. At the application level it's in the correct space, but when we WHERE ... AND spacePHID IN (...) we can incorrectly filter it out.

Test Plan
  • Did the above setup.
  • Saved "Crab", saw the space fix itself.
  • Put things back in the broken state.
  • Ran the migration script, saw things fix themselves again.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 30 2019, 2:04 AM
Owners added a subscriber: Restricted Owners Package.Jan 30 2019, 2:04 AM
epriestley requested review of this revision.Jan 30 2019, 2:06 AM
aeiser added a subscriber: aeiser.Jan 30 2019, 2:25 AM
amckinley accepted this revision.Jan 31 2019, 2:39 AM
This revision is now accepted and ready to land.Jan 31 2019, 2:39 AM
This revision was automatically updated to reflect the committed changes.