HomePhabricator

Improve handling of "Deny" responses from Duo

Description

Improve handling of "Deny" responses from Duo

Summary:
Ref T13231. See https://discourse.phabricator-community.org/t/duo-integration-crashes-if-user-is-not-enrolled-and-enrollment-is-disabled/2340/5

(There's an actual bug here, although I'm not sure exactly what's going on on the Duo side in the report.)

Test Plan:
To reproduce this, I was only able to actually "Deny" my account explicitly in Duo.

  • With "Deny", tried to add a factor. Got a nice helpful error message.
  • Undenied, added a factor, re-denied, tried to pass an MFA gate. Got another nice helpful error message.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13231

Differential Revision: https://secure.phabricator.com/D20065

Details

Provenance
epriestleyAuthored on Jan 30 2019, 4:45 AM
epriestleyPushed on Jan 31 2019, 3:33 AM
Reviewer
amckinley
Differential Revision
D20065: Improve handling of "Deny" responses from Duo
Parents
rP93b512b63cca: Update a factor query in TransactionEditor for providers
Branches
Unknown
Tags
Unknown
Tasks
T13231: Duo MFA Support
Build Status
Buildable 21779
Build 29720: Run Core Tests