Page MenuHomePhabricator

Correct a bug where milestone "spacePHID" columns could become desynchronized
ClosedPublic

Authored by epriestley on Jan 30 2019, 2:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 5:22 PM
Unknown Object (File)
Wed, Mar 27, 5:22 PM
Unknown Object (File)
Wed, Mar 27, 5:22 PM
Unknown Object (File)
Wed, Mar 27, 5:22 PM
Unknown Object (File)
Sat, Mar 23, 12:35 PM
Unknown Object (File)
Sat, Mar 23, 12:35 PM
Unknown Object (File)
Sat, Mar 23, 12:35 PM
Unknown Object (File)
Sat, Mar 23, 12:35 PM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D20041. See PHI1046. If you do this:

  • Create a parent project called "Crab" in Space 1.
  • Create a milestone called "Left Claw".
  • Shift "Crab" to Space 2.
  • Create a milestone called "Right Claw".

...you currently end up with "Left Claw" in the wrong spacePHID in the database. At the application level it's in the correct space, but when we WHERE ... AND spacePHID IN (...) we can incorrectly filter it out.

Test Plan
  • Did the above setup.
  • Saved "Crab", saw the space fix itself.
  • Put things back in the broken state.
  • Ran the migration script, saw things fix themselves again.

Diff Detail

Repository
rP Phabricator
Branch
subtype3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21754
Build 29687: Run Core Tests
Build 29686: arc lint + arc unit