Page MenuHomePhabricator

Adjust Google Auth Adapter to use Open ID Connect

Authored by dragoon20 on Jan 23 2019, 9:11 AM.


Group Reviewers
Blessed Reviewers

Google planned to shutdown Google+ API because of
security vulnerabilities.

Test Plan
  • Locally, try to setup google authentication account and try login.

Diff Detail

rPHU libphutil
Lint OK
Unit Tests OK
Build Status
Buildable 21639
Build 29505: arc lint + arc unit

Event Timeline

dragoon20 created this revision.Jan 23 2019, 9:11 AM
dragoon20 requested review of this revision.Jan 23 2019, 9:11 AM
dragoon20 updated this revision to Diff 47783.Jan 23 2019, 9:14 AM

Update some uncommitted code

epriestley requested changes to this revision.Jan 23 2019, 11:29 AM

We'll ship a patch for this in the next release (see T13227) but this patch doesn't look quite right.

This is helpful as a starting point, but there are some related Auth changes I want to make at the same time (e.g., T5591) anyway.


This looks wrong ("famiily" is misspelled).


This looks wrong, since the message is adjusted but the parameters are not, so the %s conversions won't line up.

This revision now requires changes to proceed.Jan 23 2019, 11:29 AM
dragoon20 updated this revision to Diff 47786.Jan 23 2019, 2:09 PM

Fix typo and wrong parameter for error message

Harbormaster completed remote builds in B21639: Diff 47786.

Hi @epriestley , thanks for looking at this patch, please help elaborate if there is something wrong with this patch.

Currently I only replace the use of access token to id token which is working.

As for T5591, maybe I can help you in another patch also, I am thinking that would need to add parameter on the login screen which resides in rP.

dragoon20 abandoned this revision.Jan 25 2019, 3:04 AM

@epriestley thanks for the other diff, it worked, closing this diff