See D19981. Make more of an effort to make sure that nothing unexpected-but-in-our-control can go awry here.
Details
Details
See unit tests.
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- mfa25
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21548 Build 29369: Run Core Tests Build 29368: arc lint + arc unit
Event Timeline
Comment Actions
- Remove PHP_INT_MIN test that only works on PHP 7.0.0 or newer.
- Add a check for mt_getrandmax() before hitting the MT code.
| src/filesystem/Filesystem.php | ||
|---|---|---|
| 576–579 | This specific test came out of the "Notes" section in the mt_rand() documentation. I think the implementation is: generate a value, normalize it to [0, max - min], then add min -- so it's only the difference between min and max that matters, not the actual value of min or max. | |