Harden "Filesystem::readRandomInteger()" against misuse and builtin failure
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 8:40 PM.

Details

Reviewers

amckinley

Commits

Summary

See D19981. Make more of an effort to make sure that nothing unexpected-but-in-our-control can go awry here.

Test Plan

See unit tests.

Repository

rPHU libphutil

Branch

mfa25

Lint

Lint Passed

Unit

Tests Passed

Build Status

	Time	Test
	0 ms	FilesystemTestCase::Unknown Unit Message ("") EXCEPTION (RuntimeException): Use of undefined constant PHP_INT_MIN - assumed 'PHP_INT_MIN' #0 /core/data/drydock/workingcopy-75/repo/libphutil/src/filesystem/__tests__/FilesystemTestCase.php(184): PhutilErrorHandler::handleError(8, 'Use of undefine...', '/core/data/dryd...', 184, Array) #1 [internal function]: FilesystemTestCase->testRandomIntegers()
	1 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 2 assertions passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 1 assertion passed.
	0 ms	AbstractDirectedGraphTestCase::Unknown Unit Message ("") 25 assertions passed.
		View Full Test Results (1 Failed · 377 Passed · 3 Skipped)

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 16 2019, 8:41 PM

Looks like PHP_INT_MIN wasn't introduced until PHP 7.

epriestley requested review of this revision.Jan 16 2019, 8:51 PM

src/filesystem/Filesystem.php
576–582	This specific test came out of the "Notes" section in the `mt_rand()` documentation. I think the implementation is: generate a value, normalize it to `[0, max - min]`, then add `min` -- so it's only the difference between `min` and `max` that matters, not the actual value of `min` or `max`.