Page MenuHomePhabricator

Implement "@{config:...}" as a real Remarkup rule
ClosedPublic

Authored by epriestley on Dec 22 2018, 12:43 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/. I want to make it easier to link to configuration from system text.

We currently use this weird hack with {{...}} that only works within Config itself. Instead, use @{config:...}, which is already used by Diviner for @{class:...}, etc., so it shouldn't conflict with anything.

Test Plan

Viewed config options, clicked links to other config options.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 22 2018, 12:43 PM
epriestley requested review of this revision.Dec 22 2018, 12:44 PM
amckinley accepted this revision.Dec 24 2018, 10:16 PM
This revision is now accepted and ready to land.Dec 24 2018, 10:16 PM
This revision was automatically updated to reflect the committed changes.