Page MenuHomePhabricator

Implement "@{config:...}" as a real Remarkup rule
ClosedPublic

Authored by epriestley on Dec 22 2018, 12:43 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/. I want to make it easier to link to configuration from system text.

We currently use this weird hack with {{...}} that only works within Config itself. Instead, use @{config:...}, which is already used by Diviner for @{class:...}, etc., so it shouldn't conflict with anything.

Test Plan

Viewed config options, clicked links to other config options.

Diff Detail

Repository
rP Phabricator
Branch
webhook1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21419
Build 29169: Run Core Tests
Build 29168: arc lint + arc unit