Page MenuHomePhabricator

In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode"
ClosedPublic

Authored by epriestley on Dec 22 2018, 12:46 PM.
Tags
None
Referenced Files
F18774666: D19929.diff
Fri, Oct 10, 4:30 PM
F18737768: D19929.diff
Wed, Oct 1, 12:32 PM
F18733879: D19929.diff
Tue, Sep 30, 10:43 PM
F18732887: D19929.diff
Tue, Sep 30, 8:23 PM
F18625623: D19929.id47583.diff
Sep 15 2025, 11:10 PM
F18510066: D19929.id.diff
Sep 5 2025, 3:45 AM
F18503729: D19929.diff
Sep 4 2025, 11:19 PM
F18466707: D19929.id47583.diff
Sep 2 2025, 10:40 AM
Subscribers
None

Details

Summary

Depends on D19928. See https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/.

Currently, we report "hook" and "silent", which are raw internal codes.

Instead, report human-readable labels so the user gets a better hint about what's going on ("In Silent Mode").

Also, render a "hey, you're in silent mode so none of this will work" reminder banner in this UI.

Test Plan

Screen Shot 2018-12-22 at 4.44.54 AM.png (1×1 px, 309 KB)

Note:

  • New warning banner.
  • Table has more human-readable text ("In Silent Mode").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable