Page MenuHomePhabricator

In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode"
ClosedPublic

Authored by epriestley on Sat, Dec 22, 12:46 PM.

Details

Summary

Depends on D19928. See https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/.

Currently, we report "hook" and "silent", which are raw internal codes.

Instead, report human-readable labels so the user gets a better hint about what's going on ("In Silent Mode").

Also, render a "hey, you're in silent mode so none of this will work" reminder banner in this UI.

Test Plan

Note:

  • New warning banner.
  • Table has more human-readable text ("In Silent Mode").

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Dec 22, 12:46 PM
epriestley requested review of this revision.Sat, Dec 22, 12:48 PM
amckinley accepted this revision.Mon, Dec 24, 10:43 PM
This revision is now accepted and ready to land.Mon, Dec 24, 10:43 PM
This revision was automatically updated to reflect the committed changes.