Page MenuHomePhabricator

In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode"

Authored by epriestley on Dec 22 2018, 12:46 PM.



Depends on D19928. See

Currently, we report "hook" and "silent", which are raw internal codes.

Instead, report human-readable labels so the user gets a better hint about what's going on ("In Silent Mode").

Also, render a "hey, you're in silent mode so none of this will work" reminder banner in this UI.

Test Plan


  • New warning banner.
  • Table has more human-readable text ("In Silent Mode").

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Dec 22 2018, 12:46 PM
epriestley requested review of this revision.Dec 22 2018, 12:48 PM
amckinley accepted this revision.Dec 24 2018, 10:43 PM
This revision is now accepted and ready to land.Dec 24 2018, 10:43 PM
This revision was automatically updated to reflect the committed changes.