Page MenuHomePhabricator

In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode"
ClosedPublic

Authored by epriestley on Dec 22 2018, 12:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 5, 9:30 AM
Unknown Object (File)
Fri, Dec 27, 6:59 PM
Unknown Object (File)
Wed, Dec 25, 9:20 PM
Unknown Object (File)
Sat, Dec 21, 12:04 AM
Unknown Object (File)
Dec 4 2024, 5:11 AM
Unknown Object (File)
Nov 28 2024, 5:40 PM
Unknown Object (File)
Nov 27 2024, 10:32 PM
Unknown Object (File)
Nov 20 2024, 7:37 PM
Subscribers
None

Details

Summary

Depends on D19928. See https://discourse.phabricator-community.org/t/firehose-webhook-not-working-with-self-hosted-requestbin-instance/2240/.

Currently, we report "hook" and "silent", which are raw internal codes.

Instead, report human-readable labels so the user gets a better hint about what's going on ("In Silent Mode").

Also, render a "hey, you're in silent mode so none of this will work" reminder banner in this UI.

Test Plan

Screen Shot 2018-12-22 at 4.44.54 AM.png (1×1 px, 309 KB)

Note:

  • New warning banner.
  • Table has more human-readable text ("In Silent Mode").

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable