Page MenuHomePhabricator

Update continue/break for php 7.3
ClosedPublic

Authored by amckinley on Dec 20 2018, 9:53 PM.
Tags
None
Referenced Files
F12844989: D19925.id47552.diff
Thu, Mar 28, 11:57 PM
Unknown Object (File)
Sat, Mar 23, 5:44 PM
Unknown Object (File)
Fri, Mar 22, 9:51 PM
Unknown Object (File)
Fri, Mar 15, 10:23 AM
Unknown Object (File)
Jan 31 2024, 10:01 AM
Unknown Object (File)
Jan 18 2024, 11:03 PM
Unknown Object (File)
Jan 18 2024, 10:36 PM
Unknown Object (File)
Dec 25 2023, 4:29 PM
Subscribers

Details

Summary

Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236

I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the break; break was intentional or not, since I'm not sure you could ever reach two consecutive break statements.

Test Plan

Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

These could all just be break; if you want, none of this is intentional.

This revision is now accepted and ready to land.Dec 20 2018, 9:56 PM

(I think you could only actually hit this by calling project.edit via the API and intentionally feeding in two conflicting transactions, but this or just break; are "obviously correct".)

This revision was automatically updated to reflect the committed changes.