Update continue/break for php 7.3
ClosedPublic
Actions

Authored by amckinley on Dec 20 2018, 9:53 PM.

Details

Reviewers

epriestley

Commits

rP2de632d4fe98: Update continue/break for php 7.3

Summary

Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236

I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the break; break was intentional or not, since I'm not sure you could ever reach two consecutive break statements.

Test Plan

Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.

Diff Detail

Repository

rP Phabricator

Branch

continue (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21403
Build 29150: Run Core Tests
Build 29149: arc lint + arc unit

Event Timeline

amckinley created this revision.Dec 20 2018, 9:53 PM

Harbormaster completed remote builds in B21403: Diff 47550.Dec 20 2018, 9:55 PM

amckinley requested review of this revision.Dec 20 2018, 9:55 PM

Herald added a subscriber: Korvin. · View Herald TranscriptDec 20 2018, 9:55 PM

These could all just be break; if you want, none of this is intentional.

This revision is now accepted and ready to land.Dec 20 2018, 9:56 PM

(I think you could only actually hit this by calling project.edit via the API and intentionally feeding in two conflicting transactions, but this or just break; are "obviously correct".)

Closed by commit rP2de632d4fe98: Update continue/break for php 7.3 (authored by amckinley). · Explain WhyDec 20 2018, 10:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

7 lines

Diff 47550

View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Update continue/break for php 7.3ClosedPublicActions