HomePhabricator

Update continue/break for php 7.3

Authored by amckinley on Thu, Dec 20, 9:50 PM.

Description

Update continue/break for php 7.3

Summary:
Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236

I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the break; break was intentional or not, since I'm not sure you could ever reach two consecutive break statements.

Test Plan: Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19925

Details

Committed
amckinleyThu, Dec 20, 10:12 PM
Pushed
amckinleyThu, Dec 20, 10:12 PM
Reviewer
epriestley
Differential Revision
D19925: Update continue/break for php 7.3
Parents
rPc72d29f401e2: Cleanup some clustering rough edges
Branches
Unknown
Tags
Unknown
Build Status
Buildable 21405
Build 29153: Run Core Tests