Page MenuHomePhabricator

Update continue/break for php 7.3
ClosedPublic

Authored by amckinley on Dec 20 2018, 9:53 PM.
Tags
None
Referenced Files
F17666224: D19925.diff
Sat, Jul 12, 8:43 PM
Unknown Object (File)
Wed, Jun 18, 9:52 PM
Unknown Object (File)
Jun 2 2025, 2:15 PM
Unknown Object (File)
Jun 1 2025, 10:51 PM
Unknown Object (File)
Apr 24 2025, 7:32 PM
Unknown Object (File)
Apr 16 2025, 3:54 AM
Unknown Object (File)
Apr 15 2025, 5:56 PM
Unknown Object (File)
Apr 14 2025, 4:03 PM
Subscribers

Details

Summary

Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236

I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the break; break was intentional or not, since I'm not sure you could ever reach two consecutive break statements.

Test Plan

Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

These could all just be break; if you want, none of this is intentional.

This revision is now accepted and ready to land.Dec 20 2018, 9:56 PM

(I think you could only actually hit this by calling project.edit via the API and intentionally feeding in two conflicting transactions, but this or just break; are "obviously correct".)

This revision was automatically updated to reflect the committed changes.