Paths

Table of Contentst

Differential D19910

Slightly modernize PholioImageQuery
ClosedPublic
Actions

Authored by epriestley on Dec 18 2018, 11:17 PM.

Tags

None

Referenced Files

	F14489498: D19910.diff
	Wed, Jan 1, 10:52 PM

	F14487992: D19910.diff
	Wed, Jan 1, 4:44 AM

	Unknown Object (File)
	Tue, Dec 31, 6:30 AM

	Unknown Object (File)
	Fri, Dec 27, 12:54 PM

	Unknown Object (File)
	Tue, Dec 17, 6:57 PM

	Unknown Object (File)
	Sun, Dec 8, 5:17 AM

	Unknown Object (File)
	Fri, Dec 6, 11:55 AM

	Unknown Object (File)
	Oct 31 2024, 12:29 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T11351: Move Pholio to EditEngine and modern APIs

Commits

rP38083f6f9efe: Slightly modernize PholioImageQuery

Summary

Ref T11351. My end goal is to remove applyInitialEffects() from Pholio to clear the way for D19897.

Start with some query modernization.

Test Plan

Browsed Pholio, nothing appeared to have changed.

Diff Detail

Repository

rP Phabricator

Branch

pholio1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21379
Build 29109: Run Core Tests
Build 29108: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 18 2018, 11:17 PM

Harbormaster completed remote builds in B21379: Diff 47525.Dec 18 2018, 11:18 PM

epriestley requested review of this revision.Dec 18 2018, 11:18 PM

epriestley added a child revision: D19911: Give Pholio images a more modern initializer method.Dec 18 2018, 11:28 PM

amckinley accepted this revision.Dec 18 2018, 11:31 PM

This revision is now accepted and ready to land.Dec 18 2018, 11:31 PM

Closed by commit rP38083f6f9efe: Slightly modernize PholioImageQuery (authored by epriestley). · Explain WhyDec 19 2018, 6:46 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

pholio/

query/

PholioImageQuery.php

33 lines

Diff 47525

View Options

src/applications/pholio/query/PholioImageQuery.php

Slightly modernize PholioImageQueryClosedPublicActions