Page MenuHomePhabricator

On the Diffusion cluster status page, improve device sort order

Authored by epriestley on Nov 15 2018, 1:42 PM.



Ref T13216. See PHI943. When you have a large number of cluster bindings for a repository, the UI sorting can be a bit hard to manage.

One install that regularly cycles repository cluster devices had a couple dozen older disabled bindings, with the enabled bindings intermingled.

Sort the UI:

  • enabled devices come first;
  • in each group, sort by name.
Test Plan

Mixed disabled/enabled bindings, loaded DiffusionRepositoryStorage page with clustering configured. Before: relatively unhelpful sort order. After: more intuitive sort order.

Diff Detail

rP Phabricator
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 15 2018, 1:42 PM
epriestley requested review of this revision.Nov 15 2018, 1:44 PM
amckinley accepted this revision.Nov 19 2018, 4:14 PM
This revision is now accepted and ready to land.Nov 19 2018, 4:14 PM
This revision was automatically updated to reflect the committed changes.