Page MenuHomePhabricator
Differential D19801

Fix all query warnings in "arc unit --everything"
ClosedPublic
Actions

Authored by epriestley on Nov 13 2018, 6:33 PM.
Tags
None
Referenced Files
F18181097: D19801.id47306.diff
Sat, Aug 16, 7:31 AM
F18112239: D19801.diff
Tue, Aug 12, 4:15 PM
F18096642: D19801.id47293.diff
Fri, Aug 8, 8:25 AM
F18095210: D19801.diff
Thu, Aug 7, 10:34 PM
F18089551: D19801.id47292.diff
Wed, Aug 6, 11:43 AM
F18086259: D19801.id.diff
Tue, Aug 5, 8:35 PM
Unknown Object (File)
Jul 1 2025, 9:02 PM
Unknown Object (File)
Jun 30 2025, 2:43 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
T13217: Upgrading: Hardening of qsprintf()
Commits
rP86fd2041484f: Fix all query warnings in "arc unit --everything"
Summary

Ref T13216. Ref T13217. Depends on D19800. This fixes all of the remaining query warnings that pop up when you run "arc unit --everything".

There's likely still quite a bit of stuff lurking around, but hopefully this covers a big set of the most common queries.

Test Plan

Ran arc unit --everything. Before change: lots of query warnings. After change: no query warnings.

Diff Detail

Repository
rP Phabricator
Branch
query5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php:416XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 21141
Build 28739: Run Core Tests
Build 28738: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 13 2018, 6:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2018, 6:33 PM
Harbormaster failed remote builds in B21141: Diff 47292!
epriestley requested review of this revision.Nov 13 2018, 6:35 PM

Failing because it depends on %Z and %LK in D19800.

epriestley updated this revision to Diff 47293.Nov 13 2018, 6:41 PM
  • Fix a couple minor oddities.
Harbormaster failed remote builds in B21142: Diff 47293!Nov 13 2018, 6:42 PM
amckinley accepted this revision.Nov 15 2018, 3:33 AM
This revision is now accepted and ready to land.Nov 15 2018, 3:33 AM
Closed by commit rP86fd2041484f: Fix all query warnings in "arc unit --everything" (authored by epriestley). · Explain WhyNov 15 2018, 11:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
config/
schema/
4 lines
diffusion/
query/
2 lines
14 lines
files/
query/
2 lines
people/
storage/
7 lines
phortune/
query/
44 lines
project/
engine/
4 lines
query/
2 lines
repository/
query/
6 lines
worker/
commitchangeparser/
4 lines
4 lines
infrastructure/
query/
policy/
2 lines
storage/
lisk/
11 lines
management/
4 lines
workflow/
70 lines

Diff 47292

View Options

src/applications/config/schema/PhabricatorConfigSchemaQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
View Options

src/applications/diffusion/query/DiffusionPathQuery.php

Loading...
View Options

src/applications/files/query/PhabricatorFileQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
View Options

src/applications/phortune/query/PhortuneAccountQuery.php

Loading...
View Options

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositoryCommitChangeParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitchangeparser/PhabricatorRepositorySvnCommitChangeParserWorker.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAOSet.php

Loading...
View Options

src/infrastructure/storage/management/PhabricatorStorageManagementAPI.php

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...
Phabricator · Built by Phacility