Page MenuHomePhabricator

Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf()
ClosedPublic

Authored by epriestley on Nov 13 2018, 6:29 PM.
Tags
None
Referenced Files
F19600469: D19800.id47291.diff
Tue, Feb 3, 3:35 AM
F19472692: D19800.diff
Wed, Jan 7, 12:16 PM
F19472691: D19800.diff
Wed, Jan 7, 12:16 PM
F19472690: D19800.diff
Wed, Jan 7, 12:15 PM
F19103447: D19800.diff
Dec 5 2025, 10:12 AM
F18905362: D19800.diff
Nov 8 2025, 1:57 PM
F18856474: D19800.diff
Nov 1 2025, 9:56 AM
F18782087: D19800.id.diff
Oct 13 2025, 12:32 AM
Subscribers
None

Details

Summary

Ref T13217. Ref T13216.

First, we still need a way to pass a raw, unsafe query to qsprintf(...) so we can apply .sql migrations. There's no way to make these "safe" so introduce a new "raw unsafe query" conversion which works like the old %Q: %Z.

Second, when bin/storage adjust adds or modifies keys, it needs to run a query like this:

ALTER TABLE x ADD KEY y (u, w);

The (u, w) part is usually a list of columns (same as %LC) but may look like (u(16), w(64)) if the key is on prefix substrings of the column values.

Introduce %LK to escape this particular kind of column list grammar.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable