Page MenuHomePhabricator

Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf()
ClosedPublic

Authored by epriestley on Nov 13 2018, 6:29 PM.
Tags
None
Referenced Files
F15444509: D19800.diff
Thu, Mar 27, 9:51 AM
F15428876: D19800.id47305.diff
Sun, Mar 23, 10:56 PM
F15381671: D19800.diff
Fri, Mar 14, 8:50 AM
F15308824: D19800.diff
Mar 6 2025, 6:42 AM
Unknown Object (File)
Feb 26 2025, 1:28 AM
Unknown Object (File)
Feb 9 2025, 1:10 PM
Unknown Object (File)
Feb 9 2025, 1:09 PM
Unknown Object (File)
Feb 9 2025, 1:09 PM
Subscribers
None

Details

Summary

Ref T13217. Ref T13216.

First, we still need a way to pass a raw, unsafe query to qsprintf(...) so we can apply .sql migrations. There's no way to make these "safe" so introduce a new "raw unsafe query" conversion which works like the old %Q: %Z.

Second, when bin/storage adjust adds or modifies keys, it needs to run a query like this:

ALTER TABLE x ADD KEY y (u, w);

The (u, w) part is usually a list of columns (same as %LC) but may look like (u(16), w(64)) if the key is on prefix substrings of the column values.

Introduce %LK to escape this particular kind of column list grammar.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable