Page MenuHomePhabricator

Fix all query warnings in "arc unit --everything"
ClosedPublic

Authored by epriestley on Tue, Nov 13, 6:33 PM.

Details

Summary

Ref T13216. Ref T13217. Depends on D19800. This fixes all of the remaining query warnings that pop up when you run "arc unit --everything".

There's likely still quite a bit of stuff lurking around, but hopefully this covers a big set of the most common queries.

Test Plan

Ran arc unit --everything. Before change: lots of query warnings. After change: no query warnings.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Tue, Nov 13, 6:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Tue, Nov 13, 6:33 PM
Harbormaster failed remote builds in B21141: Diff 47292!
epriestley requested review of this revision.Tue, Nov 13, 6:35 PM

Failing because it depends on %Z and %LK in D19800.

epriestley updated this revision to Diff 47293.Tue, Nov 13, 6:41 PM
  • Fix a couple minor oddities.
amckinley accepted this revision.Thu, Nov 15, 3:33 AM
This revision is now accepted and ready to land.Thu, Nov 15, 3:33 AM
This revision was automatically updated to reflect the committed changes.