Page MenuHomePhabricator

Add "%Z" (Raw Query) and "%LK" (List of Columns for Keys) to qsprintf()
ClosedPublic

Authored by epriestley on Nov 13 2018, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 3, 7:35 PM
Unknown Object (File)
Mon, Jun 30, 10:21 AM
Unknown Object (File)
Sun, Jun 29, 4:55 AM
Unknown Object (File)
Fri, Jun 27, 4:59 PM
Unknown Object (File)
Fri, Jun 27, 5:36 AM
Unknown Object (File)
Thu, Jun 26, 4:04 AM
Unknown Object (File)
Thu, Jun 19, 11:05 PM
Unknown Object (File)
Thu, Jun 19, 2:23 PM
Subscribers
None

Details

Summary

Ref T13217. Ref T13216.

First, we still need a way to pass a raw, unsafe query to qsprintf(...) so we can apply .sql migrations. There's no way to make these "safe" so introduce a new "raw unsafe query" conversion which works like the old %Q: %Z.

Second, when bin/storage adjust adds or modifies keys, it needs to run a query like this:

ALTER TABLE x ADD KEY y (u, w);

The (u, w) part is usually a list of columns (same as %LC) but may look like (u(16), w(64)) if the key is on prefix substrings of the column values.

Introduce %LK to escape this particular kind of column list grammar.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable