Page MenuHomePhabricator
Differential D19798

Put push log "hookWait" to data export and add all wait values to UI
ClosedPublic
Actions

Authored by epriestley on Nov 8 2018, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 9:01 AM
Unknown Object (File)
Fri, Apr 19, 8:05 PM
Unknown Object (File)
Mar 19 2024, 10:33 PM
Unknown Object (File)
Mar 19 2024, 10:32 PM
Unknown Object (File)
Mar 19 2024, 10:32 PM
Unknown Object (File)
Mar 19 2024, 10:32 PM
Unknown Object (File)
Mar 5 2024, 5:16 PM
Unknown Object (File)
Feb 3 2024, 7:51 PM
View All 64 Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13216: 2018 Week 45-47 Bonus Content
Commits
rP1d7c960531be: Put push log "hookWait" to data export and add all wait values to UI
Summary

Depends on D19797. Ref T13216.

  • Put the new hookWait in the export and the UI.
  • Put the existing waits in the UI, not just the export.
  • Make order consistent: host, write, read, hook (this is the order the timers start in).
Test Plan

Pushed some stuff, viewed web UI and saw sensible numbers, exported data and got the same values.

Diff Detail

Repository
rP Phabricator
Branch
rlog2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21120
Build 28713: Run Core Tests
Build 28712: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2018, 5:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 6:00 PM
Harbormaster failed remote builds in B21120: Diff 47272!
epriestley added a child revision: D19799: Add a basic web UI for intracluster sync logs.Nov 8 2018, 6:17 PM
epriestley requested review of this revision.Nov 8 2018, 6:20 PM

Test failures are just on phutil_microseconds_since(...).

amckinley accepted this revision.Nov 9 2018, 6:58 PM
This revision is now accepted and ready to land.Nov 9 2018, 6:58 PM
Closed by commit rP1d7c960531be: Put push log "hookWait" to data export and add all wait values to UI (authored by epriestley). · Explain WhyNov 10 2018, 12:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
protocol/
2 lines
view/
34 lines
repository/
query/
10 lines

Diff 47272

View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
Phabricator · Built by Phacility