Page MenuHomePhabricator

Put push log "hookWait" to data export and add all wait values to UI

Authored by epriestley on Nov 8 2018, 5:59 PM.
Referenced Files
F13205302: D19798.diff
Wed, May 15, 1:48 AM
F13188703: D19798.diff
Sat, May 11, 5:25 AM
Unknown Object (File)
Tue, May 7, 9:07 AM
Unknown Object (File)
Fri, May 3, 8:48 AM
Unknown Object (File)
Wed, May 1, 8:32 PM
Unknown Object (File)
Thu, Apr 25, 2:36 AM
Unknown Object (File)
Sat, Apr 20, 9:01 AM
Unknown Object (File)
Fri, Apr 19, 8:05 PM



Depends on D19797. Ref T13216.

  • Put the new hookWait in the export and the UI.
  • Put the existing waits in the UI, not just the export.
  • Make order consistent: host, write, read, hook (this is the order the timers start in).
Test Plan

Pushed some stuff, viewed web UI and saw sensible numbers, exported data and got the same values.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 6:00 PM
Harbormaster failed remote builds in B21120: Diff 47272!

Test failures are just on phutil_microseconds_since(...).

This revision is now accepted and ready to land.Nov 9 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.