Page MenuHomePhabricator

Put push log "hookWait" to data export and add all wait values to UI
ClosedPublic

Authored by epriestley on Nov 8 2018, 5:59 PM.

Details

Summary

Depends on D19797. Ref T13216.

  • Put the new hookWait in the export and the UI.
  • Put the existing waits in the UI, not just the export.
  • Make order consistent: host, write, read, hook (this is the order the timers start in).
Test Plan

Pushed some stuff, viewed web UI and saw sensible numbers, exported data and got the same values.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Nov 8 2018, 5:59 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 6:00 PM
Harbormaster failed remote builds in B21120: Diff 47272!
epriestley requested review of this revision.Nov 8 2018, 6:20 PM

Test failures are just on phutil_microseconds_since(...).

amckinley accepted this revision.Nov 9 2018, 6:58 PM
This revision is now accepted and ready to land.Nov 9 2018, 6:58 PM
This revision was automatically updated to reflect the committed changes.