Page MenuHomePhabricator
Differential D19797

Use phutil_microseconds_since(...) to simplify some timing arithmetic
ClosedPublic
Actions

Authored by epriestley on Nov 8 2018, 3:33 PM.
Tags
None
Referenced Files
F15308790: D19797.id47275.diff
Thu, Mar 6, 6:40 AM
F15308789: D19797.id47271.diff
Thu, Mar 6, 6:40 AM
F15308788: D19797.id.diff
Thu, Mar 6, 6:40 AM
F15308786: D19797.diff
Thu, Mar 6, 6:40 AM
Unknown Object (File)
Mon, Mar 3, 2:24 PM
Unknown Object (File)
Fri, Feb 14, 8:10 PM
Unknown Object (File)
Feb 9 2025, 6:39 AM
Unknown Object (File)
Feb 9 2025, 6:39 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rPc32fa0626610: Use phutil_microseconds_since(...) to simplify some timing arithmetic
Summary

Depends on D19796. Simplify some timing code by using phutil_microseconds_since() instead of duplicate casting and arithmetic.

Test Plan

Grepped for 1000000 to find these. Pulled, pushed, made a conduit call. This isn't exhaustive but it should be hard for these to break in a bad way since they're all just diagnostic.

Diff Detail

Repository
rP Phabricator
Branch
rlog1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21119
Build 28711: Run Core Tests
Build 28710: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 8 2018, 3:33 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 3:34 PM
Harbormaster failed remote builds in B21119: Diff 47271!
epriestley requested review of this revision.Nov 8 2018, 4:54 PM
epriestley retitled this revision from Use phutil_microseconds_since(...) to simplify some to Use phutil_microseconds_since(...) to simplify some timing arithmetic.

Tests failed since we don't have phutil_microseconds_since() in master yet (until D19796).

epriestley added a child revision: D19798: Put push log "hookWait" to data export and add all wait values to UI.Nov 8 2018, 5:59 PM
amckinley accepted this revision.Nov 8 2018, 8:21 PM

Grepped for 1000000 to find these.

So we only found the callsites that do have the correct number of zeroes 😢

This revision is now accepted and ready to land.Nov 8 2018, 8:21 PM
epriestley added a comment.Nov 8 2018, 8:24 PM

hahaha

grep 10000 | grep -v 1000000 doesn't seem to turn up anything suspicious so I suspect we're okay.

Closed by commit rPc32fa0626610: Use phutil_microseconds_since(...) to simplify some timing arithmetic (authored by epriestley). · Explain WhyNov 9 2018, 12:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
scripts/
ssh/
2 lines
src/
applications/
conduit/
controller/
4 lines
ssh/
4 lines
diffusion/
engine/
3 lines
protocol/
7 lines
infrastructure/
daemon/
workers/
storage/
3 lines
support/
startup/
2 lines

Diff 47271

View Options

scripts/ssh/ssh-exec.php

Loading...
View Options

src/applications/conduit/controller/PhabricatorConduitAPIController.php

Loading...
View Options

src/applications/conduit/ssh/ConduitSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/protocol/DiffusionRepositoryClusterEngine.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php

Loading...
View Options

support/startup/PhabricatorStartup.php

Loading...
Phabricator · Built by Phacility