Page MenuHomePhabricator

Use phutil_microseconds_since(...) to simplify some timing arithmetic
ClosedPublic

Authored by epriestley on Nov 8 2018, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 10:32 PM
Unknown Object (File)
Tue, Mar 19, 10:31 PM
Unknown Object (File)
Tue, Mar 19, 10:31 PM
Unknown Object (File)
Tue, Mar 19, 10:31 PM
Unknown Object (File)
Thu, Mar 7, 5:53 AM
Unknown Object (File)
Dec 27 2023, 12:55 PM
Unknown Object (File)
Dec 22 2023, 12:44 AM
Unknown Object (File)
Dec 15 2023, 4:03 PM
Subscribers
None

Details

Summary

Depends on D19796. Simplify some timing code by using phutil_microseconds_since() instead of duplicate casting and arithmetic.

Test Plan

Grepped for 1000000 to find these. Pulled, pushed, made a conduit call. This isn't exhaustive but it should be hard for these to break in a bad way since they're all just diagnostic.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2018, 3:34 PM
Harbormaster failed remote builds in B21119: Diff 47271!
epriestley retitled this revision from Use phutil_microseconds_since(...) to simplify some to Use phutil_microseconds_since(...) to simplify some timing arithmetic.

Tests failed since we don't have phutil_microseconds_since() in master yet (until D19796).

Grepped for 1000000 to find these.

So we only found the callsites that do have the correct number of zeroes 😢

This revision is now accepted and ready to land.Nov 8 2018, 8:21 PM

hahaha

grep 10000 | grep -v 1000000 doesn't seem to turn up anything suspicious so I suspect we're okay.

This revision was automatically updated to reflect the committed changes.