Differential D19790

Continue making application fixes to Phabricator for changes to %Q semantics
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 12:59 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP2f10d4adebf9: Continue making application fixes to Phabricator for changes to %Q semantics

Summary

Depends on D19789. Ref T13217. Continue updating things to use the new %Q-flavored conversions instead of smushing a bunch of strings together.

Test Plan

Browsed around, far fewer errors. These changes are largely mechanical in nature.

Diff Detail

Repository

rP Phabricator

Branch

qobject9

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21106
Build 28690: Run Core Tests
Build 28689: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	1 ms	AphrontIsolatedDatabaseConnectionTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', '%s INTO %s (%s)...') #1 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', '%s INTO %s (%s)...')
	1 ms	AphrontMySQLDatabaseConnectionTestCase::Unknown Unit Message ("") EXCEPTION (AphrontConnectionLostQueryException): #2006: Simulated error. This error may occur if your configured MySQL "wait_timeout" or "max_allowed_packet" values are too small. This may also indicate that something used the MySQL "KILL <process>" command to kill the connection running the query.
	2 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-91/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
		View Full Test Results (125 Failed · 269 Passed)