Make SELECT construction in PolicyAwareQuery safer
ClosedPublic
Actions

Authored by epriestley on Nov 7 2018, 10:40 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP64b52b9952dd: Make SELECT construction in PolicyAwareQuery safer

Summary

Depends on D19784. Ref T13217. Reduce uses of unsafe %Q in SELECT construction.

Test Plan

This reduces the number of safety warnings when loading Phabricator home from ~900 to ~800.

Diff Detail

Repository

rP Phabricator

Branch

qobject5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21100
Build 28678: Run Core Tests
Build 28677: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	2 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	1 ms	ConpherenceRoomTestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
	2 ms	DiffusionURITestCase::Unknown Unit Message ("") EXCEPTION (XsprintfUnknownConversionException): Unknown conversion LQ. #0 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(282): qsprintf_check_scalar_type(Array, 'LQ', 'SELECT %LQ') #1 /core/data/drydock/workingcopy-71/repo/libphutil/src/xsprintf/qsprintf.php(134): qsprintf_check_type(Array, 'LQ', 'SELECT %LQ')
		View Full Test Results (100 Failed · 260 Passed)