Page MenuHomePhabricator

Prevent users from voting for invalid Slowvote options
ClosedPublic

Authored by epriestley on Nov 5 2018, 6:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:22 PM
Unknown Object (File)
Thu, Apr 11, 10:52 AM
Unknown Object (File)
Sat, Apr 6, 8:17 AM
Unknown Object (File)
Fri, Apr 5, 7:34 PM
Unknown Object (File)
Mon, Apr 1, 8:04 AM
Unknown Object (File)
Mar 19 2024, 3:42 PM
Unknown Object (File)
Mar 19 2024, 3:41 PM
Unknown Object (File)
Mar 19 2024, 3:41 PM
Subscribers
None

Details

Summary

Depends on D19773. See https://hackerone.com/reports/434116. You can currently vote for invalid options by submitting, e.g., vote[]=12345.

By doing this, you can see the responses, which is sort of theoretically a security problem? This is definitely a bug, regardless.

Instead, only allow users to vote for options which are actually part of the poll.

Test Plan
  • Tried to vote for invalid options by editing the form to vote[]=12345 (got error).
  • Tried to vote for invalid options by editing the radio buttons on a plurality poll into checkboxes, checking multiple boxes, and submitting (got error).
  • Voted in approval and plurality polls the right way, from the main web UI and from the embed ({V...}) UI.

Diff Detail

Repository
rP Phabricator
Branch
xvote2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21082
Build 28649: Run Core Tests
Build 28648: arc lint + arc unit