Page MenuHomePhabricator

Replace magical "branch" behavior in "diffusion.branchquery" with an explicit "patterns"
ClosedPublic

Authored by epriestley on Nov 2 2018, 3:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 15, 12:06 PM
Unknown Object (File)
Feb 3 2024, 7:45 PM
Unknown Object (File)
Dec 27 2023, 12:54 PM
Unknown Object (File)
Dec 23 2023, 12:24 PM
Unknown Object (File)
Dec 22 2023, 12:37 AM
Unknown Object (File)
Dec 21 2023, 1:08 AM
Unknown Object (File)
Nov 30 2023, 1:28 AM
Unknown Object (File)
Nov 15 2023, 3:00 PM
Subscribers
None

Details

Summary

See PHI958. Ref T13210. Previously, see PHI720.

The use case for the magic in PHI720 involves multiple patterns, and no parameter can be passed to branch that will result in multiple patterns being passed to git.

Replace the implicit magic with an explicit patterns parameter.

This whole thing is a bit shaky but probably isn't hurting anything.

Test Plan
  • Ran query with no patterns.
  • Ran query with invalid patterns, got readable error.
  • Ran query with various valid patterns (plain branch name, globs with "?" and "*"), got sensible results.

Diff Detail

Repository
rP Phabricator
Branch
branchquery1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21077
Build 28641: Run Core Tests
Build 28640: arc lint + arc unit