HomePhabricator

Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics

Description

Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics

Summary:
Ref T13217. This method is slightly tricky:

  • We can't safely return a string: return an array instead.
  • It no longer makes sense to accept glue. All callers use ', ' as glue anyway, so hard-code that.

Then convert all callsites.

Test Plan: Browsed around, saw fewer "unsafe" errors in error log.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13217

Differential Revision: https://secure.phabricator.com/D19784

Details

Provenance
epriestleyAuthored on Nov 7 2018, 12:57 AM
epriestleyPushed on Nov 13 2018, 4:59 PM
Reviewer
amckinley
Differential Revision
D19784: Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics
Parents
rP315d857a8ad6: Add a basic web UI for intracluster sync logs
Branches
Unknown
Tags
Unknown
Tasks
T13217: Upgrading: Hardening of qsprintf()
Build Status
Buildable 21139
Build 28735: Run Core Tests