Page MenuHomePhabricator

Replace magical "branch" behavior in "diffusion.branchquery" with an explicit "patterns"
ClosedPublic

Authored by epriestley on Nov 2 2018, 3:18 AM.
Tags
None
Referenced Files
F15462544: D19771.diff
Tue, Apr 1, 3:51 PM
F15431010: D19771.id47297.diff
Mon, Mar 24, 10:07 AM
F15419867: D19771.diff
Fri, Mar 21, 9:32 AM
F15385512: D19771.id.diff
Fri, Mar 14, 10:45 PM
F15383560: D19771.diff
Fri, Mar 14, 5:10 PM
F15283742: D19771.id47297.diff
Tue, Mar 4, 8:24 AM
Unknown Object (File)
Feb 20 2025, 7:01 AM
Unknown Object (File)
Feb 9 2025, 6:38 AM
Subscribers
None

Details

Summary

See PHI958. Ref T13210. Previously, see PHI720.

The use case for the magic in PHI720 involves multiple patterns, and no parameter can be passed to branch that will result in multiple patterns being passed to git.

Replace the implicit magic with an explicit patterns parameter.

This whole thing is a bit shaky but probably isn't hurting anything.

Test Plan
  • Ran query with no patterns.
  • Ran query with invalid patterns, got readable error.
  • Ran query with various valid patterns (plain branch name, globs with "?" and "*"), got sensible results.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable