Correct an ambiguous regexp in DiffusionRequest
ClosedPublic
Actions

Authored by epriestley on Nov 2 2018, 2:56 AM.

Details

Reviewers

amckinley
avivey

Commits

rP24a061f84495: Correct an ambiguous regexp in DiffusionRequest

Summary

See https://discourse.phabricator-community.org/t/diffusionrequest-regex-error/2057/.

The intent of [\d-,] is "digits, hyphen, and comma" but [x-y] means "character range x-y".

Specify [\d,-] instead to disambiguate the hyphen as "literal hyphen", not a character range marker.

Test Plan

I can't reproduce the original error as reported, but browsed around Diffusion for a bit.

Diff Detail

Repository

rP Phabricator

Branch

range1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21074
Build 28637: Run Core Tests
Build 28636: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 2 2018, 2:56 AM

Harbormaster completed remote builds in B21074: Diff 47227.Nov 2 2018, 2:58 AM

epriestley requested review of this revision.Nov 2 2018, 2:58 AM

avivey accepted this revision.Nov 2 2018, 3:00 AM

This revision is now accepted and ready to land.Nov 2 2018, 3:00 AM

Closed by commit rP24a061f84495: Correct an ambiguous regexp in DiffusionRequest (authored by epriestley). · Explain WhyNov 2 2018, 3:01 AM

This revision was automatically updated to reflect the committed changes.

Thanks, this is similar to the solution I came up with.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

request/

DiffusionRequest.php

2 lines

Diff 47227

View Options

src/applications/diffusion/request/DiffusionRequest.php

Correct an ambiguous regexp in DiffusionRequestClosedPublicActions