Page MenuHomePhabricator

Correct an ambiguous regexp in DiffusionRequest
ClosedPublic

Authored by epriestley on Nov 2 2018, 2:56 AM.
Tags
None
Referenced Files
F12807634: D19770.id47227.diff
Wed, Mar 27, 7:45 PM
Unknown Object (File)
Tue, Mar 19, 3:38 PM
Unknown Object (File)
Sun, Mar 17, 5:09 PM
Unknown Object (File)
Sat, Mar 16, 10:34 AM
Unknown Object (File)
Mon, Mar 4, 10:33 PM
Unknown Object (File)
Fri, Mar 1, 4:15 AM
Unknown Object (File)
Feb 21 2024, 12:13 PM
Unknown Object (File)
Feb 16 2024, 2:49 AM
Subscribers

Details

Summary

See https://discourse.phabricator-community.org/t/diffusionrequest-regex-error/2057/.

The intent of [\d-,] is "digits, hyphen, and comma" but [x-y] means "character range x-y".

Specify [\d,-] instead to disambiguate the hyphen as "literal hyphen", not a character range marker.

Test Plan

I can't reproduce the original error as reported, but browsed around Diffusion for a bit.

Diff Detail

Repository
rP Phabricator
Branch
range1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21074
Build 28637: Run Core Tests
Build 28636: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Nov 2 2018, 3:00 AM
This revision was automatically updated to reflect the committed changes.

Thanks, this is similar to the solution I came up with.