Page MenuHomePhabricator

When including files, also print E_COMPILE_ERROR to avoid dying silently
ClosedPublic

Authored by epriestley on Aug 24 2018, 5:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 26, 3:45 AM
Unknown Object (File)
Feb 22 2024, 10:02 PM
Unknown Object (File)
Feb 19 2024, 2:57 AM
Unknown Object (File)
Jan 30 2024, 4:37 AM
Unknown Object (File)
Dec 31 2023, 11:44 PM
Unknown Object (File)
Dec 27 2023, 12:50 PM
Unknown Object (File)
Dec 27 2023, 12:50 PM
Unknown Object (File)
Dec 27 2023, 12:50 PM
Subscribers
None

Details

Summary

Ref T12190. Ref T13187. I accidentally double-defined a method, which caused arc unit to exit silently under PHP 7.1.16.

Under this version of PHP, at least, this error raises an E_COMPILE_ERROR inside include_once() and never returns.

Test Plan
  • Double define a testWhatever() method under PHP 7.1.16.
  • Run arc unit --everything.
  • Before patch: silent fatal.
  • After patch: useful error.

Diff Detail

Repository
rPHU libphutil
Branch
cerror1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 20665
Build 28086: Run Core Tests
Build 28085: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:58 PM
This revision was automatically updated to reflect the committed changes.