Page MenuHomePhabricator
Differential D19598

Condition "Changes Since Last Action" Differential link on "first broadcast", not "new object"
ClosedPublic
Actions

Authored by epriestley on Aug 24 2018, 4:52 PM.
Tags
None
Referenced Files
F18103124: D19598.id46858.diff
Sun, Aug 10, 1:54 AM
F17947532: D19598.id.diff
Thu, Jul 31, 5:11 PM
F17930324: D19598.diff
Wed, Jul 30, 5:54 PM
Unknown Object (File)
Jun 29 2025, 5:46 PM
Unknown Object (File)
May 29 2025, 3:37 PM
Unknown Object (File)
May 28 2025, 5:32 PM
Unknown Object (File)
May 7 2025, 1:43 PM
Unknown Object (File)
Apr 27 2025, 3:59 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13176: Differential now has a "/D123/new/" link
T13187: Plans: 2018 Week 34 Bonus Content
Commits
rP5e4d9dfa9219: Condition "Changes Since Last Action" Differential link on "first broadcast"…
Summary

Ref T13187. Ref T13176. With drafts, we actually want to suppress this link on "first broadcast" (the first time we send mail), not on "new object" (when the revision is created as a draft).

Test Plan

Poked at this locally, will keep an eye on it in production.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Aug 24 2018, 4:52 PM
Harbormaster completed remote builds in B20657: Diff 46856.Aug 24 2018, 4:53 PM
epriestley requested review of this revision.Aug 24 2018, 4:53 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:04 PM
Closed by commit rP5e4d9dfa9219: Condition "Changes Since Last Action" Differential link on "first broadcast"… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
editor/
2 lines

Diff 46858

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
Phabricator · Built by Phacility