Differential D19598

Condition "Changes Since Last Action" Differential link on "first broadcast", not "new object"
ClosedPublic
Actions

Authored by epriestley on Aug 24 2018, 4:52 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13176: Differential now has a "/D123/new/" link
T13187: Plans: 2018 Week 34 Bonus Content

Commits

rP5e4d9dfa9219: Condition "Changes Since Last Action" Differential link on "first broadcast"…

Summary

Ref T13187. Ref T13176. With drafts, we actually want to suppress this link on "first broadcast" (the first time we send mail), not on "new object" (when the revision is created as a draft).

Test Plan

Poked at this locally, will keep an eye on it in production.

Diff Detail

Repository

rP Phabricator

Branch

newlink1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20657
Build 28074: Run Core Tests
Build 28073: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 24 2018, 4:52 PM

Harbormaster completed remote builds in B20657: Diff 46856.Aug 24 2018, 4:53 PM

epriestley requested review of this revision.Aug 24 2018, 4:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 24 2018, 5:04 PM

Closed by commit rP5e4d9dfa9219: Condition "Changes Since Last Action" Differential link on "first broadcast"… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

2 lines

Diff 46856

View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Condition "Changes Since Last Action" Differential link on "first broadcast", not "new object"ClosedPublicActions