Page MenuHomePhabricator
Differential D19556

Allow push events to be filtered by which Herald rule blocked the push
ClosedPublic
Actions

Authored by epriestley on Aug 1 2018, 7:43 PM.
Tags
None
Referenced Files
F18086955: D19556.id46757.diff
Wed, Aug 6, 1:25 AM
F17945135: D19556.id.diff
Thu, Jul 31, 11:18 AM
F17937472: D19556.id46753.diff
Thu, Jul 31, 1:16 AM
F17926231: D19556.diff
Wed, Jul 30, 12:48 PM
F17919598: D19556.id.diff
Wed, Jul 30, 2:43 AM
F17880013: D19556.diff
Mon, Jul 28, 9:07 PM
Unknown Object (File)
May 30 2025, 8:14 PM
Unknown Object (File)
May 29 2025, 11:29 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13164: Plans: 2018 Week 31 - 33 Bonus Content
Commits
rP06380e8079de: Allow push events to be filtered by which Herald rule blocked the push
Summary

Depends on D19555. Ref T13164. See PHI765. An install is interested in getting a sense of the impact of a particular blocking rule, which seems reasonable. Support filtering for pushes blocked by a particular rule or set of rules.

Test Plan

Screen Shot 2018-08-01 at 12.42.41 PM.png (969×1 px, 158 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 46757

View Options

src/applications/repository/query/PhabricatorRepositoryPushLogQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryPushLogSearchEngine.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPushEvent.php

Loading...
Phabricator · Built by Phacility