Page MenuHomePhabricator

When a Herald rule blocks a push, show which rule fired in the push log UI
ClosedPublic

Authored by epriestley on Aug 1 2018, 3:58 PM.
Tags
None
Referenced Files
F15411771: D19555.diff
Wed, Mar 19, 9:45 AM
Unknown Object (File)
Feb 9 2025, 6:14 AM
Unknown Object (File)
Feb 9 2025, 6:14 AM
Unknown Object (File)
Feb 9 2025, 6:14 AM
Unknown Object (File)
Jan 30 2025, 8:25 AM
Unknown Object (File)
Jan 29 2025, 2:38 PM
Unknown Object (File)
Jan 28 2025, 3:57 AM
Unknown Object (File)
Jan 25 2025, 1:47 AM
Subscribers
None

Details

Summary

Ref T13164. See PHI765. We currently show "Rejected: Herald" in the push log UI, but don't show which rule rejected a push.

We store this data, and it's potentially useful: either for hunting down a particular issue, or for getting a general sense of how often a reject rule is triggering (maybe because you want to tune how aggressive it is).

Show this data in the web UI, and include it in the data export payload.

Test Plan
  • Pushed to a hosted repository so that I got blocked by a Herald rule.
  • Viewed the push logs in the web UI, now saw which rule triggered things.
  • Exported logs to CSV, saw Herald rule PHIDs in the data.

Screen Shot 2018-08-01 at 8.38.59 AM.png (1×1 px, 173 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable