Page MenuHomePhabricator

Use more consistent diff coloration in unified diffs
ClosedPublic

Authored by epriestley on Jun 8 2018, 3:04 PM.
Tags
None
Referenced Files
F12850696: D19482.id46595.diff
Fri, Mar 29, 5:45 AM
Unknown Object (File)
Mon, Mar 4, 11:03 PM
Unknown Object (File)
Feb 20 2024, 2:12 PM
Unknown Object (File)
Feb 3 2024, 7:00 PM
Unknown Object (File)
Dec 30 2023, 3:22 PM
Unknown Object (File)
Dec 20 2023, 8:30 AM
Unknown Object (File)
Dec 14 2023, 6:09 PM
Unknown Object (File)
Nov 30 2023, 1:01 AM
Subscribers
None

Details

Summary

Ref T13151. See PHI701. Unified diffs are currently missing the logic to apply the "old-full" and "new-full" classes, which results in a too-light coloration for fully added or removed lines.

Make this logic consistent with the two-up renderer so we use the same colors in both.

Test Plan

Viewed diffs and swapped between 1-up and 2-up renderers, now saw the same coloration.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable