Differential D19482

Use more consistent diff coloration in unified diffs
ClosedPublic
Actions

Authored by epriestley on Jun 8 2018, 3:04 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13151: Plans: 2018 Week 23 - Week 30 Bonus Content

Commits

rPf37542717774: Use more consistent diff coloration in unified diffs

Summary

Ref T13151. See PHI701. Unified diffs are currently missing the logic to apply the "old-full" and "new-full" classes, which results in a too-light coloration for fully added or removed lines.

Make this logic consistent with the two-up renderer so we use the same colors in both.

Test Plan

Viewed diffs and swapped between 1-up and 2-up renderers, now saw the same coloration.

Diff Detail

Repository

rP Phabricator

Branch

bright1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20399
Build 27701: Run Core Tests
Build 27700: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 8 2018, 3:04 PM

Harbormaster completed remote builds in B20399: Diff 46595.Jun 8 2018, 3:05 PM

epriestley requested review of this revision.Jun 8 2018, 3:05 PM

amckinley accepted this revision.Jun 8 2018, 4:09 PM

This revision is now accepted and ready to land.Jun 8 2018, 4:09 PM

Closed by commit rPf37542717774: Use more consistent diff coloration in unified diffs (authored by epriestley). · Explain WhyJun 8 2018, 4:39 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13161: Plans: Improve Differential diff display behaviors.Feb 16 2019, 2:18 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetOneUpRenderer.php

12 lines

Diff 46595

View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Use more consistent diff coloration in unified diffsClosedPublicActions