Page MenuHomePhabricator

Use more consistent diff coloration in unified diffs
ClosedPublic

Authored by epriestley on Jun 8 2018, 3:04 PM.

Details

Summary

Ref T13151. See PHI701. Unified diffs are currently missing the logic to apply the "old-full" and "new-full" classes, which results in a too-light coloration for fully added or removed lines.

Make this logic consistent with the two-up renderer so we use the same colors in both.

Test Plan

Viewed diffs and swapped between 1-up and 2-up renderers, now saw the same coloration.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jun 8 2018, 3:04 PM
epriestley requested review of this revision.Jun 8 2018, 3:05 PM
amckinley accepted this revision.Jun 8 2018, 4:09 PM
This revision is now accepted and ready to land.Jun 8 2018, 4:09 PM
This revision was automatically updated to reflect the committed changes.