Fix "Any Owner" and "No Owners" searches in Maniphest
ClosedPublic
Actions

Authored by epriestley on May 9 2018, 8:01 PM.

Details

Reviewers

Commits

rP8ada2bc4fe74: (stable) Fix "Any Owner" and "No Owners" searches in Maniphest
rP10a4b05ecba6: Fix "Any Owner" and "No Owners" searches in Maniphest

Summary

See https://discourse.phabricator-community.org/t/maniphest-home-page-crash-after-d19417/1445/3. These special-token-only searches currently end up populating an empty ownerPHIDs, which fatals after the stricter check in D19417.

Make the fatal on withConstraint(array()) explicit and only set the PHID constraint if we have some PHIDs left.

Test Plan

Searched for "No Owner", "Any Owner", an actual owner, "No Owner + actual user".

Diff Detail

Repository

rP Phabricator

Branch

xsearch1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 20302
Build 27564: Run Core Tests
Build 27563: arc lint + arc unit

Event Timeline

epriestley created this revision.May 9 2018, 8:01 PM

Harbormaster completed remote builds in B20302: Diff 46494.May 9 2018, 8:02 PM

epriestley requested review of this revision.May 9 2018, 8:02 PM

amckinley accepted this revision.May 9 2018, 8:23 PM

This revision is now accepted and ready to land.May 9 2018, 8:23 PM

Closed by commit rP10a4b05ecba6: Fix "Any Owner" and "No Owners" searches in Maniphest (authored by epriestley). · Explain WhyMay 9 2018, 8:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

query/

ManiphestTaskQuery.php

10 lines

Diff 46494

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Fix "Any Owner" and "No Owners" searches in ManiphestClosedPublicActions