Page MenuHomePhabricator
Differential D19417

More-robust search for task assignees
ClosedPublic
Actions

Authored by amckinley on Apr 30 2018, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 2:37 PM
Unknown Object (File)
Sat, Nov 9, 3:15 PM
Unknown Object (File)
Oct 21 2024, 12:09 PM
Unknown Object (File)
Oct 21 2024, 12:09 PM
Unknown Object (File)
Oct 16 2024, 11:43 PM
Unknown Object (File)
Oct 4 2024, 9:37 PM
Unknown Object (File)
Oct 1 2024, 7:55 PM
Unknown Object (File)
Sep 18 2024, 5:57 AM
View All Files
Subscribers
Korvin
Taffer

Details

Reviewers
epriestley
Commits
rPdd6e82698aeb: More-robust search for task assignees
Summary

See discussion in D19415.

Test Plan

Searched for some owners, found tasks as expected.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

amckinley created this revision.Apr 30 2018, 7:11 PM
Harbormaster completed remote builds in B20257: Diff 46446.Apr 30 2018, 7:13 PM
amckinley requested review of this revision.Apr 30 2018, 7:13 PM
Herald added a subscriber: Korvin. · View Herald TranscriptApr 30 2018, 7:13 PM
epriestley accepted this revision.Apr 30 2018, 7:16 PM
This revision is now accepted and ready to land.Apr 30 2018, 7:16 PM
Closed by commit rPdd6e82698aeb: More-robust search for task assignees (authored by amckinley). · Explain WhyApr 30 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.
Taffer added a subscriber: Taffer.May 7 2018, 5:50 PM

This actually caused an AphrontParameterQueryException while loading the Maniphest home page due to $this->ownerPHIDs being an empty array. I attempted to fix it by changing line 588 to:

if (($this->ownerPHIDs !== null) and !empty($this->ownerPHIDs)) {

which seems to work. I have no idea what side-effects this "fix" might cause though, I'm still waiting for my team to complain.

epriestley added a comment.May 7 2018, 5:52 PM

If you'd like that fixed, please file a bug report on the Discourse forum, including reproduction instructions that others can follow to reproduce the issue. A link to a page on this install which fatals would be sufficient.

Taffer added a comment.May 7 2018, 6:06 PM

Report filed, cheers!

epriestley mentioned this in D19440: Fix "Any Owner" and "No Owners" searches in Maniphest.May 9 2018, 8:01 PM
epriestley mentioned this in rP10a4b05ecba6: Fix "Any Owner" and "No Owners" searches in Maniphest.May 9 2018, 8:24 PM
amckinley mentioned this in rP8ada2bc4fe74: (stable) Fix "Any Owner" and "No Owners" searches in Maniphest.May 9 2018, 10:08 PM

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
2 lines

Diff 46448

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
Phabricator · Built by Phacility