Fix "Any Owner" and "No Owners" searches in Maniphest
ClosedPublic
Actions

Authored by epriestley on May 9 2018, 8:01 PM.

Details

Reviewers

Commits

Summary

See https://discourse.phabricator-community.org/t/maniphest-home-page-crash-after-d19417/1445/3. These special-token-only searches currently end up populating an empty ownerPHIDs, which fatals after the stricter check in D19417.

Make the fatal on withConstraint(array()) explicit and only set the PHID constraint if we have some PHIDs left.

Test Plan

Searched for "No Owner", "Any Owner", an actual owner, "No Owner + actual user".

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

epriestley requested review of this revision.May 9 2018, 8:02 PM

This revision is now accepted and ready to land.May 9 2018, 8:23 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

maniphest/

query/

10 lines