Page MenuHomePhabricator
Differential D19440

Fix "Any Owner" and "No Owners" searches in Maniphest
ClosedPublic
Actions

Authored by epriestley on May 9 2018, 8:01 PM.
Tags
None
Referenced Files
F19513100: D19440.id.diff
Jan 13 2026, 7:46 AM
F19251290: D19440.id46501.diff
Dec 22 2025, 8:30 AM
F18756690: D19440.id46494.diff
Oct 5 2025, 12:45 PM
F18753109: D19440.id46501.diff
Oct 4 2025, 5:26 PM
F18509625: D19440.id.diff
Sep 5 2025, 3:30 AM
F18502866: D19440.diff
Sep 4 2025, 10:42 PM
F18478253: D19440.diff
Sep 3 2025, 5:49 AM
F18229819: D19440.id.diff
Aug 20 2025, 11:35 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP8ada2bc4fe74: (stable) Fix "Any Owner" and "No Owners" searches in Maniphest
rP10a4b05ecba6: Fix "Any Owner" and "No Owners" searches in Maniphest
Summary

See https://discourse.phabricator-community.org/t/maniphest-home-page-crash-after-d19417/1445/3. These special-token-only searches currently end up populating an empty ownerPHIDs, which fatals after the stricter check in D19417.

Make the fatal on withConstraint(array()) explicit and only set the PHID constraint if we have some PHIDs left.

Test Plan

Searched for "No Owner", "Any Owner", an actual owner, "No Owner + actual user".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
query/
10 lines

Diff 46501

View Options

src/applications/maniphest/query/ManiphestTaskQuery.php

Loading...
Phabricator · Built by Phacility