Paths

Table of Contentst

Differential D19200

PhabricatorMemeEngine HA HA HA HA
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 5:38 PM.

Details

Reviewers: None
Maniphest Tasks: T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rPc7408f27977d: PhabricatorMemeEngine HA HA HA HA

Summary

Depends on D19198. Ref T13101. Ref T5258. Pull compositing logic out of the Controller.

This is moving toward fixing memes in email.

Test Plan

Used new and old memes. Used API memes.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 8 2018, 5:38 PM

Harbormaster completed remote builds in B19797: Diff 45981.Mar 8 2018, 5:40 PM

epriestley requested review of this revision.Mar 8 2018, 5:40 PM

epriestley added a child revision: D19201: Somewhat improve meme transform code so it is merely very bad.Mar 8 2018, 6:50 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:07 PM

Closed by commit rPc7408f27977d: PhabricatorMemeEngine HA HA HA HA (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13172: Saved meme-maker results are case-insensitive.Jul 20 2018, 10:26 PM

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

macro/

conduit/

MacroCreateMemeConduitAPIMethod.php

21 lines

controller/

PhabricatorMacroMemeController.php

100 lines

engine/

PhabricatorMemeEngine.php

163 lines

markup/

PhabricatorMemeRemarkupRule.php

30 lines

Diff 45987

View Options

src/__phutil_library_map__.php

View Options

src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php

View Options

src/applications/macro/controller/PhabricatorMacroMemeController.php

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

View Options

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

PhabricatorMemeEngine HA HA HA HAClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45987

src/__phutil_library_map__.php

src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php

src/applications/macro/controller/PhabricatorMacroMemeController.php

src/applications/macro/engine/PhabricatorMemeEngine.php

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

PhabricatorMemeEngine HA HA HA HA
ClosedPublic
Actions

Revision Contents
Changeset List