Page MenuHomePhabricator
Differential D19200

PhabricatorMemeEngine HA HA HA HA
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 5:38 PM.
Tags
None
Referenced Files
F16572270: D19200.diff
Tue, Jun 17, 3:34 AM
Unknown Object (File)
Sat, May 31, 12:13 PM
Unknown Object (File)
Sat, May 31, 11:27 AM
Unknown Object (File)
Fri, May 30, 6:23 AM
Unknown Object (File)
Thu, May 29, 5:30 AM
Unknown Object (File)
May 10 2025, 10:50 AM
Unknown Object (File)
Apr 8 2025, 8:40 AM
Unknown Object (File)
Apr 7 2025, 9:08 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T5258: Memes use older image transform code without modern error handling
T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits
rPc7408f27977d: PhabricatorMemeEngine HA HA HA HA
Summary

Depends on D19198. Ref T13101. Ref T5258. Pull compositing logic out of the Controller.

This is moving toward fixing memes in email.

Test Plan

Used new and old memes. Used API memes.

Diff Detail

Repository
rP Phabricator
Branch
meme3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19797
Build 26821: Run Core Tests
Build 26820: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
macro/
conduit/
21 lines
controller/
100 lines
engine/
163 lines
markup/
30 lines

Diff 45981

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/macro/conduit/MacroCreateMemeConduitAPIMethod.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroMemeController.php

Loading...
View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

Loading...
View Options

src/applications/macro/markup/PhabricatorMemeRemarkupRule.php

Loading...
Phabricator · Built by Phacility