Differential D19203

Possibly fix memes in email
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 7:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 5:40 AM

	Unknown Object (File)
	Sun, Feb 9, 5:40 AM

	Unknown Object (File)
	Sun, Feb 9, 5:40 AM

	Unknown Object (File)
	Tue, Jan 28, 10:32 PM

	Unknown Object (File)
	Tue, Jan 28, 10:31 PM

	Unknown Object (File)
	Tue, Jan 28, 10:31 PM

	Unknown Object (File)
	Tue, Jan 28, 3:34 AM

	Unknown Object (File)
	Sat, Jan 25, 12:39 AM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rP10b3ddf42657: Possibly fix memes in email

Summary

Depends on D19201. Ref T13101. This likely produces relatively stable-ish image references for email.

They currently TTL after 30 days but this makes the jokes more exclusive and special so it's a feature, not a bug.

Test Plan

I'm just going to test this in production because I'm a ninja superstar developer.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 8 2018, 7:04 PM

Harbormaster completed remote builds in B19801: Diff 45985.Mar 8 2018, 7:05 PM

epriestley requested review of this revision.Mar 8 2018, 7:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:09 PM

Closed by commit rP10b3ddf42657: Possibly fix memes in email (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

engine/

PhabricatorMemeEngine.php

5 lines

markup/

PhabricatorMemeRemarkupRule.php

81 lines

Diff 45989

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php